Re: [PATCH v9 08/11] trailer: add tests for "git interpret-trailers"

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 1, 2014, 22:54 UTC
Message-ID: <xmqqa9c4y823.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140401192023.353.56221.chriscool@tuxfamily.org>

Christian Couder <chriscool@tuxfamily.org> writes:

Show 8 quoted lines

> +test_expect_success '--trim-empty without config' '
> +	cat >expected <<-\EOF &&
> +		ack: Peff
> +		Acked-by: Johan
> +	EOF
> +	git interpret-trailers --trim-empty "ack = Peff" "Reviewed-by" "Acked-by: Johan" "sob:" >actual &&
> +	test_cmp expected actual
> +'

Let's avoid these overlong and unreadable lines by doing something like this (just one hunk shown for illustration):

 		ack: Peff
 		Acked-by: Johan
 	EOF
-	git interpret-trailers --trim-empty "ack = Peff" "Reviewed-by" "Acked-by: Johan" "sob:" >actual &&
+	git interpret-trailers --trim-empty "ack = Peff" \
+		"Reviewed-by" "Acked-by: Johan" "sob:" >actual &&
 	test_cmp expected actual
 '

I've queued the series on 'pu' with the 'chop-overlong-lines' and another minor fix squashed in; hopefully we can merge to 'next' soonish.

Thanks.