Re: [PATCH] git-new-workdir: support submodules

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 26, 2015, 04:05 UTC
Message-ID: <xmqqa916nq4p.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CAGXKyzEPWrbRFOhvCBm=2Z50zso85G50z-nLd_wyzyeEADQSmw@mail.gmail.com>

Craig Silverstein <csilvers@khanacademy.org> writes:

Show 10 quoted lines

> } Or one new-workdir checkout's branch may check out a top-level
> } project from today while the other one may have a top-level project
> } from two years ago,
>
> This is also true, but just as much a problem with the 'git
> new-workdir' script as it existed before my change.  It already
> symlinks the top-level .git/config directory, which lists a remote,
> submodules, and many other things.  Does symlinking the config file
> for submodules add any new wrinkles, that symlinking the config file
> for the top-level repository does not?

The update under discussion is labeled as "support submodules"; presumably the only reason that such an update is good is because it will fix existing problems that makes the use of the script break when submodules are involved --- submodules are not supported with the current code, and this patch fixes the code to support it.

But then, you are saying that the update does not fix these existing issues around submodule support. So...?