git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH V2 0/2] git-p4: Small updates to test cases

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 28, 2015, 16:07 UTC
Message-ID
<xmqqa8yxyukb.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1427500983-8802-1-git-send-email-vitor.hda@gmail.com>
Will apply both.

It seems that I am to blame for 1/2 for botching the shell syntax X-<. Thanks for fixing.

I was not entirely happy with the "we could find either file10 or file11 because they are the same, so let's declare both are success" in the original, f69b3a93 (git p4 test: copy source indeterminate, 2012-06-27) in the first place, which survived the 9b6513ac (git p4 test: split up big t9800 test, 2012-06-27) and e832f737 (t9814: fix misconversion from test $a -o $b to test $a || test $b, 2014-07-25). I think a better fix would have been not to have multiple identical copies in the tested tree to begin with.

But 2/2 is an acceptable interim fix that uses the same approach as we have been using since f69b3a93, so it should do at least for now.

Thanks.
Previous: Vitor Antunes
Message 4 of 4 in “git-p4: Small updates to test cases”
  1. 0/2 git-p4: Small updates to test casesVitor Antunes, Mar 28, 2015
  2. 1/2 git-p4: Make rename test case runnable under dashVitor Antunes, Mar 28, 2015
  3. 2/2 git-p4: Fix copy detection testVitor Antunes, Mar 28, 2015
  4. Junio C HamanoMar 28, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.