Re: [PATCH v4] git-rebase--interactive.sh: add config option for custom instruction format

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 12, 2015, 20:56 UTC
Message-ID: <xmqqa8w4d4sc.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1434075808-43453-2-git-send-email-rappazzo@gmail.com>

Michael Rappazzo <rappazzo@gmail.com> writes:

Show 12 quoted lines

> A config option 'rebase.instructionFormat' can override the
> default 'oneline' format of the rebase instruction list.
>
> Since the list is parsed using the left, right or boundary mark plus
> the sha1, they are prepended to the instruction format.
>
> Signed-off-by: Michael Rappazzo <rappazzo@gmail.com>
> ---
>  Documentation/git-rebase.txt |  7 +++++++
>  git-rebase--interactive.sh   | 20 +++++++++++++++++---
>  t/t3415-rebase-autosquash.sh | 21 +++++++++++++++++++++
>  3 files changed, 45 insertions(+), 3 deletions(-)

Thanks, will replace.

The autosquash part somehow makes me feel uneasy, though. The feature fundamentally has to have %s as the first thing in the format to work, but by making the format overridable, you are potentially breaking that feature, aren't you?