Re: [PATCH] git-p4: add "--path-encoding" option

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 31, 2015, 20:09 UTC
Message-ID: <xmqqa8t7usmk.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <55E4A965.8040305@web.de>

Torsten Bögershausen <tboegi@web.de> writes:

Show 10 quoted lines

> On 2015-08-31 19.40, Junio C Hamano wrote:
>> larsxschneider@gmail.com writes:
>
>>> +test_expect_success 'Create a repo containing cp1251 encoded paths' '
>>> +	cd "$cli" &&
>>> +
>>> +	FILENAME="$(echo "a-¤_o-¶_u-¼.txt" | iconv -f utf-8 -t cp1252)" &&
>>  ...
> Using file names and iconv like this may not be portable:
> - cp1252 may be called CP1252 (or may not be available)

"git grep 'cp[0-9]' t/" does tell us that we refrain from using them and I am sure the portability worries is a big reason. Thank you for pointing it out.

> - reading from stdin is not necessarily supported by iconv

"git grep '| iconv' t/" tells me that this is irrelevant; we already heavily depend on it.

> - creating files in CP1252 may not be supported under Mac OS
>    (Not sure about Windows)

The same as the first point, which is a good thing to worry about.

> One solution could be to use ISO-8859-1, convert into UTF-8,
> and "convert into UTF-8" one more time.

I do not quite get it; do you need to do anything more than just replacing cp1252 with iso-8859-1 in the patch being discussed?