git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] format-patch: add an option to suppress commit hash

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 8, 2015, 18:18 UTC
Message-ID
<xmqqa8pkls7f.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20151208010227.GC990758@vauxhall.crustytoothpaste.net>
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
Show 7 quoted lines
>> Don't test "any number of '0'"; test 40 '0's.  This is because the
>> line format was designed to be usable by things like /etc/magic to
>> detect format-patch output, and we want to notice if/when we break
>> that aspect of our output format.
>
> My idea was to future-proof it against changes in the hash function,
> although that's in the distant future.

Making sure that the test fails when somebody accidentally lengthens (or fails to truncate to 40-hex, when you start using a longer hash) the displayed name there is a good future-proofing.

Thanks.
Previous: brian m. carlsonNext: Junio C Hamano
Message 7 of 10 in “format-patch: introduce option to suppress commit hashes”
  1. 0/2 format-patch: introduce option to suppress commit hashesbrian m. carlson, Dec 6, 2015
  2. 1/2 Introduce a null_oid constant.brian m. carlson, Dec 6, 2015
  3. 2/2 format-patch: add an option to suppress commit hashbrian m. carlson, Dec 6, 2015
  4. Junio C HamanoDec 7, 2015
  5. Junio C HamanoDec 7, 2015
  6. brian m. carlsonDec 8, 2015
  7. Junio C HamanoDec 8, 2015
  8. Junio C HamanoDec 7, 2015
  9. brian m. carlsonDec 7, 2015
  10. Junio C HamanoDec 7, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.