Re: [PATCH 2/5] t1404: document function test_update_rejected

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 9, 2016, 16:05 UTC
Message-ID: <xmqqa8iujqkv.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <57598F2F.9050806@alum.mit.edu>

Michael Haggerty <mhagger@alum.mit.edu> writes:

Show 8 quoted lines

> On 06/07/2016 06:57 PM, Johannes Sixt wrote:
>> Am 07.06.2016 um 13:50 schrieb Michael Haggerty:
>>>   test_update_rejected () {
>>> +    local prefix before pack create error &&
>> 
>> Do we want to add more of unportable 'local' declarations?
>
> Sorry, I forgot that `local` is not in the POSIX standard.

Regarding portability we say three things.

 * It is supported practically everywhere, and it is even in POSIX,
   so let's use it.

 * Even this is not in POSIX, it is supported practically
   everywhere, and it is too cumbersome to do things without using
   it, so let's use it.

 * It is not available in some platforms we (collectively) still
   care; it is not even in POSIX.  Don't use it.

I think "local" falls into the third one.

: bash; ksh $ v=1 $ f () { local v; v=2; echo f; } $ f ksh: local: not found [No such file or directory] f $ echo $v 2 $ exit : bash;