Re: [PATCH 2/4] add smudge-to-file and clean-from-file filter configuration

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 17, 2016, 18:24 UTC
Message-ID: <xmqqa8ij1xne.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160617180650.GA16404@kitenet.net>

Joey Hess <id@joeyh.name> writes:

Show 5 quoted lines

> Or we could pick one of the two methods of appending the file
> (I prefer not including a space before it as more flexible), and
> anything using this interface would need to design its command line
> parsing with this interface in mind, and would probably choose to use
> --to-file=foo rather than --to-file foo.

When I gave the example in the message you are responding to, I chose to assume that we will always have a space there, and this was to to avoid a problem that will become common if we did otherwise, namely:

    [filter "foo"] cleanFromFile = command

which must be spelled as

    [filter "foo"] cleanFromFile = "command "

to separate the command name with it argument if we didn't add the space there.

I tend to agree with what you said in the other response, i.e. "Probably anything using this interface is gonna be implemented with the interface in mind from the beginning", so they will not have an issue if the interface always added a space there, and there is the "sh -c" thing if they really want to do something unusual.