git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/2] diff --no-index: support symlinks and pipes

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 20, 2017, 16:02 UTC
Message-ID
<xmqqa88gx7gj.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<1490006404.15470.12.camel@kaarsemaker.net>
Dennis Kaarsemaker <dennis@kaarsemaker.net> writes:
Show 13 quoted lines
> On Sun, 2017-03-19 at 15:08 -0700, Junio C Hamano wrote:
> ...
>> > - A --derefence option was added and the default is no longer to dereference
>> >   symlinks.
>> 
>> I do agree that it makes sense to have --[no-]dereference options,
>> but I do not think it was my feedback and suggestion to make it
>> optional (not default) to dereference, so please do not blame me for
>> that choice.
>
> Then I misinterpreted your message at 
> http://public-inbox.org/git/xmqqk29yedkv.fsf@gitster.mtv.corp.google.com/
> No blame inteded, my apologies for coming across as blaming.

s/blame/credit/ then. I do not too deeply care which one is the default, and if we were adding --no-index without any existing users today, I probably would suggest making it deref by default (i.e. to make "diff --no-index" match better what other peoples' diffs do), but that would be a behaviour change to existing users if done today, so I think what you did probably is a good thing.

Thanks.
Previous: Dennis Kaarsemaker
Message 8 of 8 in “diff --no-index: support symlinks and pipes”
  1. 0/2 diff --no-index: support symlinks and pipesDennis Kaarsemaker, Mar 18, 2017
  2. 2/2 diff --no-index: support reading from pipesDennis Kaarsemaker, Mar 18, 2017
  3. 1/2 diff --no-index: optionally follow symlinksDennis Kaarsemaker, Mar 18, 2017
  4. Junio C HamanoMar 19, 2017
  5. Dennis KaarsemakerMar 20, 2017
  6. Junio C HamanoMar 19, 2017
  7. Dennis KaarsemakerMar 20, 2017
  8. Junio C HamanoMar 20, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.