git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv3] rebase: pass --[no-]signoff option to git am

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 15, 2017, 10:03 UTC
Message-ID
<xmqqa87im1hf.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<CAOxFTcwDrYvg5Nf1w9SfmM=Nt7XYsJPhKSYkJzMC0123EY94Aw@mail.gmail.com>
Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
Show 7 quoted lines
>> We need new tests for "git rebase --signoff" that makes sure this
>> works as expected and only when it should.
>
> Would the norm in this case be to introduce the test in the same
> commit, or in a previous commit (as in: this is the feature we want to
> implement, it obviously doesn't work now, but the next commit will fix
> that), or in a subsequent one?

For a new feature (especially with this small implementation), it is best to have the test in the same commit.

We often use the "start with expect_failure, update the code while flipping _failure to _success" pattern but that is primarily suitable for bugfixes.

Previous: Giuseppe Bilotta
Message 4 of 4 in “[PATCHv3] rebase: pass --[no-]signoff option to git am”
  1. Giuseppe BilottaApr 14, 2017
  2. Junio C HamanoApr 15, 2017
  3. Giuseppe BilottaApr 15, 2017
  4. Junio C HamanoApr 15, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.