Re: Solaris 11.3 SPARC grep problem with t1450-fsck.sh

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 27, 2017, 16:25 UTC
Message-ID: <xmqqa84t2yaa.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAKKM46uJLu+w-UUFZc1HRar3apAD6Db2KD+GjiNL5v+Q2Ni7hA@mail.gmail.com>

Michael Kebe <michael.kebe@gmail.com> writes:

Show 19 quoted lines

> Running the test suite on Solaris 11.3 SPARC fails on a test in t1450-fsck.sh.
>
> not ok 60 - fsck --name-objects
> #
> #               rm -rf name-objects &&
> #               git init name-objects &&
> #               (
> #                       cd name-objects &&
> #                       test_commit julius caesar.t &&
> #                       test_commit augustus &&
> #                       test_commit caesar &&
> #                       remove_object $(git rev-parse julius:caesar.t) &&
> #                       test_must_fail git fsck --name-objects >out &&
> #                       tree=$(git rev-parse --verify julius:) &&
> #                       grep "$tree (\(refs/heads/master\|HEAD\)@{[0-9]*}:" out
> #               )
>
> Solaris has /usr/bin/grep and /usr/bin/ggrep. grep is a solaris
> version and ggrep is the GNU grep.

We do not need GNUism, but many tools that come in /usr/bin have been found unfit. I thought that Solaris users were expected to set SANE_TOOL_PATH to point at /usr/xpg[46]/bin to avoid this problem.

Ah, wait, that particular grep may have GNUism. If you changed it to

    egrep "$tree \((refs/heads/master|HEAD)@{[0-9]*}:" out

does it make it pass for you?