Re: [RFC PATCH] builtin/worktree: enhance worktree removal
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 22, 2017, 02:12 UTC
- Message-ID
- <xmqqa7zfxdru.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <CAPig+cQrC1MiPrwwPqtdX2tzj1ntFHxO28uqnMBcmVpPPrc_Rg@mail.gmail.com>
Eric Sunshine <sunshine@sunshineco.com> writes:
Show 10 quoted lines
> Let me see if I understand. Sometimes you know that you've deleted the > worktree directory, in which case 'git worktree prune' is the obvious > choice. However, there may be cases when you've forgotten that you > deleted the worktree directory (or it got deleted some other way), yet > it still shows up in "git worktree list" output with no indication > that it has been deleted (though, ideally, it should tell you so[1]). > In this case, you see a worktree that you know you no longer want, so > you invoke "git worktree remove" but that errors out because the > actual directory is already gone. This patch make the operation > succeed, despite the missing directory. Is that correct?
Hmph, so the user could be using "git worktree prune" after seeing the error? Was there a reason behind "git worktree remove" to be extra careful to make sure both existed before going forward, or was this a simple oversight?