git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] perf: amend the grep tests to test grep.threads

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 5, 2018, 22:28 UTC
Message-ID
<xmqqa7xsaqki.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<87o9m8asys.fsf@evledraar.gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 16 quoted lines
>> Judging by the way the other side uses "test_perf $prereq ..."
>> without quotes around it, I suspect you do expect it to be empty in
>> some cases.  It means you expect test_have_prereq is prepared to
>> skip an empty prerequisite in a prereq list, but I do not recall
>> writing that helper in such a way, so...
>>
>> 	PTHREADS${prereq:+,}$prereq
>>
>> or something along that line, perhaps?
>
> It's not, but a trailing comma at the end of the prereq list works since
> test_have_prereq() relies on setting the IFS to ",", so as long as this
> is portable:
> ...
> We could use the ${...} pattern above if you prefer, but since it
> doesn't appear to be needed...

I view that reasoning as depending more on how the helper happens to be implemented right now than working by design, though.

Previous: Ævar Arnfjörð Bjarmason
Message 4 of 4 in “perf: amend the grep tests to test grep.threads”
  1. perf: amend the grep tests to test grep.threadsÆvar Arnfjörð Bjarmason, Dec 29, 2017
  2. Junio C HamanoJan 4, 2018
  3. Ævar Arnfjörð BjarmasonJan 5, 2018
  4. Junio C HamanoJan 5, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.