Re: [PATCH v2] checkout files in-place
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 11, 2018, 22:46 UTC
- Message-ID
- <xmqqa7s1aqlm.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <87a7s1vw9a.fsf@evledraar.gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> ...And this seems to conflict with what Junio's summarized in > xmqqvaapb3r1.fsf@gitster-ct.c.googlers.com. I.e. (if I'm reading it > correctly) it's not correct to say that we unlink the existing file, > then replace it, don't we create a new one, and then rename it in-place?
No, my recollection was incorrect. entry.c::checkout_entry() does an unlink() then write_entry() to the final place without any rename-to-finish phase.