Re: [PATCH 1/6] git-submodule.sh: align error reporting for update mode to use path

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 12, 2018, 21:12 UTC
Message-ID: <xmqqa7qwupje.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180712194754.71979-2-sbeller@google.com>

Stefan Beller <sbeller@google.com> writes:

Show 5 quoted lines

> All other error messages in cmd_update are reporting the submodule based
> on its path, so let's do that for invalid update modes, too.
>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---

Makes sense.

Show 16 quoted lines

>  git-submodule.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/git-submodule.sh b/git-submodule.sh
> index 5f9d9f6ea37..8a611865397 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -627,7 +627,7 @@ cmd_update()
>  				must_die_on_failure=yes
>  				;;
>  			*)
> -				die "$(eval_gettext "Invalid update mode '$update_module' for submodule '$name'")"
> +				die "$(eval_gettext "Invalid update mode '$update_module' for submodule path '$path'")"
>  			esac
>  
>  			if (sanitize_submodule_env; cd "$sm_path" && $command "$sha1")