Re: Re* [PATCH v7 1/1] sideband: highlight keywords in remote sideband output
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 20, 2018, 14:21 UTC
- Message-ID
- <xmqqa7phce4d.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20180818232220.GA24533@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 10 quoted lines
>> In the longer term we may want to accept size_t as parameter for >> clarity (even though we know that a sideband message we are painting >> typically would fit on a line on a terminal and int is sufficient). >> Write it down as a NEEDSWORK comment. > > This "typically" made me nervous about what happens in the non-typical > case, but I think we can say something even stronger: the length comes > from a pktline, so the maximum is less than 16 bits. I wondered if we > might ever call this on the accumulated string from multiple sidebands, > but it doesn't look like it.
I think a sideband packet may be split on one but not the other codepath to result in multiple calls, but I do not think we coalesce them together, so I agree that int is sufficient.