Re: RFE: git-patch-id should handle patches without leading "diff"

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 8, 2018, 06:01 UTC
Message-ID: <xmqqa7lg8sko.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20181207223406.GD73340@google.com>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 13 quoted lines

>> So it seems most sensible to me if this is going to be supported that we
>> go a bit beyond the call of duty and fake up the start of it, namely:
>>
>>     --- a/arch/x86/kernel/process.c
>>     +++ b/arch/x86/kernel/process.c
>>
>> To be:
>>
>>     diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
>>     --- a/arch/x86/kernel/process.c
>>     +++ b/arch/x86/kernel/process.c
>
> Right.  We may want to handle diff.mnemonicPrefix as well.

I definitely think under the --stable option, we should pretend as if the canonical a/ vs b/ prefixes were given with the "diff --git" header, just like we try to reverse the effect of diff-orderfile, etc.

I am unsure what the right behaviour under --unstable is, though.