git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] packfile: use extra variable to clarify code in use_pack()

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 14, 2019, 05:38 UTC
Message-ID
<xmqqa7hy9fse.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20190314001940.GD31968@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 5 quoted lines
> I think it does apply, though the reasoning in the commit message of
> "this is OK because 'left' is large enough" becomes a lot more
> hand-wavy. The patch is not making anything _worse_, certainly, but the
> fact of the matter is that "left" still might not be big enough, if it
> is not a size_t.

True; it does not make much sense without the actual size_t conversion, I would think.

Previous: Ramsay Jones
Message 5 of 5 in “packfile: use extra variable to clarify code in use_pack()”
  1. packfile: use extra variable to clarify code in use_pack()Ramsay Jones, Mar 13, 2019
  2. Ramsay JonesMar 13, 2019
  3. Jeff KingMar 14, 2019
  4. Ramsay JonesMar 14, 2019
  5. Junio C HamanoMar 14, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.