git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] setup: tweak upgrade policy to grandfather worktreeconfig

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 14, 2020, 04:27 UTC
Message-ID
<xmqqa702n2kv.fsf@gitster.c.googlers.com>
In-Reply-To
<20200714040616.GA2208896@google.com>
Jonathan Nieder <jrnieder@gmail.com> writes:
Show 10 quoted lines
> It's too late to go that far for 2.28.  It would be tempting to try a
> simple revert of 14c7fa269e4 (check_repository_format_gently(): refuse
> extensions for old repositories, 2020-06-05) to get back to tried and
> true behavior but that does not do enough --- it still produces an
> error when trying to upgrade repository format when any extensions are
> set.  So how about such a revert plus Junio's patch plus the analogous
> change to Junio's patch for
>
>   extensions.preciousObjects
>   extensions.partialClone

My illustration patch was done "assuming that worktreeconfig is the only thing we wrote by mistake without updating the format version", and if these two also share the same problem, I obviously is 100% fine with covering these other ones with the same approach.

I like your "v0 and v1 are the same, but the repository is declared to be corrupt if the extentions that are not known by today's code is found in v0 repository", by the way. Assuming that the two you listed above plus worktreeconfig are the only ones known by today's code, that is. We seem to also know about "noop", so shouldn't it also be grandfathered in?

Previous: Jonathan NiederNext: Derrick Stolee via GitGitGadget
Message 10 of 15 in “setup: warn if extensions exist on old format”
  1. setup: warn if extensions exist on old formatDerrick Stolee via GitGitGadget, Jul 13, 2020
  2. Taylor BlauJul 13, 2020
  3. Derrick StoleeJul 13, 2020
  4. Junio C HamanoJul 13, 2020
  5. Junio C HamanoJul 13, 2020
  6. setup: tweak upgrade policy to grandfather worktreeconfigJunio C Hamano, Jul 13, 2020
  7. Derrick StoleeJul 13, 2020
  8. Junio C HamanoJul 13, 2020
  9. Jonathan NiederJul 14, 2020
  10. Junio C HamanoJul 14, 2020
  11. 0/2 setup: warn if extensions exist on old formatDerrick Stolee via GitGitGadget, Jul 14, 2020
  12. 1/2 setup: tweak upgrade policy to grandfather worktreeconfigDerrick Stolee via GitGitGadget, Jul 14, 2020
  13. Johannes SchindelinJul 14, 2020
  14. 2/2 config: provide extra detail about worktree configDerrick Stolee via GitGitGadget, Jul 14, 2020
  15. Johannes SchindelinJul 14, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.