Re: [PATCH 2/2] checkout-index: omit entries with no tempname from --temp output

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 10, 2021, 01:07 UTC
Message-ID: <xmqqa6scyblz.fsf@gitster.c.googlers.com>
In-Reply-To: <CAHd-oW4ddei-bRZkQUSpMevyZYgOBi2T6uQPzJ_XscTmfxhWtw@mail.gmail.com>

Matheus Tavares Bernardino <matheus.bernardino@usp.br> writes:

Show 9 quoted lines

>> Hmph, is topath[][] array used after this function gets called and
>> in what way?  Whether have_tempname is true or not, wouldn't we want
>> to clear it?
>
> Yeah, topath[][] can be reused in the next checkout_entry() call. But
> if have_tempname is false, the positions that are going to be used
> again (either checkout_stage or 1, 2, and 3, if checkout_stage ==
> CHECKOUT_ALL) will be already empty. So I think we only need to clear
> topath[][] when have_tempname is false.

If so, clearing them unconditionally like the original code before the introduction of have_tempname variable would be easier on readers, as they won't be forced to reason about when to and when not to clear these strings---figure out if the reason why we do not always clear is because (1) we have info that we do not want to lose if (!have_tempname), or (2) we know there is nothing to be cleared if (!have_tempname).

Thanks.