Re: [PATCH] Docs: web server must setenv GIT_PROTOCOL for v2

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 9, 2021, 17:35 UTC
Message-ID: <xmqqa6kl1wjs.fsf@gitster.g>
In-Reply-To: <xmqqee9x1wvh.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 7 quoted lines

>> @@ -789,6 +790,9 @@ int cmd_main(int argc, const char **argv)
>>  	http_config();
>>  	max_request_buffer = git_env_ulong("GIT_HTTP_MAX_REQUEST_BUFFER",
>>  					   max_request_buffer);
>> +	proto_header = getenv("HTTP_GIT_PROTOCOL");
>> +	if (proto_header)
>> +		setenv(GIT_PROTOCOL_ENVIRONMENT, proto_header, 1);

Since this overwrites (I noticed the "1" at the end), the server operator cannot force a particular protocol with their server configuration, no?

Would a weaker form to use 0 (set if there isn't any, but keep the value if somebody else already has set it) work OK? Would that have a downside?