Re: [PATCH 2/4] refs: trim newline from reflog message

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 29, 2021, 02:30 UTC
Message-ID: <xmqqa6hn4rsj.fsf@gitster.g>
In-Reply-To: <CAFQ2z_N-XY6MrvYjKvkH-vNz1824p12aNeiHj8m8VPzPD0JxEA@mail.gmail.com>

Han-Wen Nienhuys <hanwen@google.com> writes:

Show 11 quoted lines

> On Wed, Nov 24, 2021 at 9:55 PM Junio C Hamano <gitster@pobox.com> wrote:
>> Ehh, let's step back a bit.
>>
>> Is there anything in the common part and files backend in ref API
>> that needs to be changed to fix some bug?  I do not see anything
>> broken that needs to be fixed by "assert that the string ends in LF
>> and doesn't need to add LF itself" or by "always add LF".
>
> Clearly, you and I disagree about what is logical behavior here.
>
> I've reworked the series to fit with your opinion on the matter. PTAL.

Thanks.

I find both are logical and internally consistent, so I prefer a choice that requires fewer changes to what is already working.