Re: [PATCH] hooks--pre-commit: detect non-ASCII when renaming

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 14, 2022, 23:08 UTC
Message-ID: <xmqqa69b2syj.fsf@gitster.g>
In-Reply-To: <xmqqedyn2t6e.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 13 quoted lines

> "Julian Prein via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
>> From: Julian Prein <druckdev@protonmail.com>
>>
>> Currently the diff-filter that is used to check for non-ASCII characters
>> in filenames only checks new additions.
>>
>> Extend the diff-filter in the pre-commit sample to include `CR` as well.
>> This way non-ASCII character in filenames are detected on a rename/copy
>> as well.
>
> It would probably be a better implementation to disable the rename
> detection, instead of adding Copies and Renames.

That is ...

>> -	test $(git diff --cached --name-only --diff-filter=A -z $against |

... instead of using the "git diff" Porcelain, we can probably use the "git diff-index" plumbing command here, which will not be affected by end-user configuration or by the fact that recent "git diff" turns on the rename detection by default.