Re: [PATCH v2] trailer: allow spaces in tokens

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 18, 2022, 21:31 UTC
Message-ID: <xmqqa681nsrv.fsf@gitster.g>
In-Reply-To: <CAP8UFD1304rQh+9jMUkTmTvmNBxm6BNDt3=d07+C8iXSbJb2RA@mail.gmail.com>

Christian Couder <christian.couder@gmail.com> writes:

Show 7 quoted lines

> I think allowing one white space before the separator is a good idea
> for the following reasons.
> ...
> I think it would be very annoying for users to find out that a number
> of otherwise proper trailers would not be taken into account only
> because they have a white space before the colon. At least there
> should be an option to allow that.

In short, you do not support Max's patch that allows arbitrary number of white spaces anywhere but at the beginning of line, but see a room for unrelated improvement from the current code, namely, to allow exactly one optional space, immediately before the separator and nowhere else.

It may be a reasonable thing to do that may not break too many things. I do not know if that is loose enough to satisify Max's original wish, though.

Thanks.