git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: vd/fix-unaligned-read-index-v4, was Re: What's cooking in git.git (Sep 2022, #08; Tue, 27)

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 28, 2022, 17:41 UTC
Message-ID
<xmqqa66jv1kb.fsf@gitster.g>
In-Reply-To
<220928.86h70rwhxh.gmgdl@evledraar.gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 20 quoted lines
> On Wed, Sep 28 2022, Junio C Hamano wrote:
>
>> Jeff King <peff@peff.net> writes:
>>
>>> ... I have no objection to adding more comments, but I am
>>> happy enough without them (like Junio, it may be that I'm overly
>>> familiar with how I expect our get_be() functions to handle alignment).
>>> ...
>>> So it's mostly just a minor annoyance for running the tests; we're
>>> probably better not to change any code, even trivially, this late in the
>>> release cycle.
>>
>> Yup.  I never planned to merge the topic to 'master'.  The finishing
>> touch I expected was to help Phillip and friends with a bit of
>> explanation in the log message, and then it would be ready to wait
>> in 'next' for the next cycle.
>
> In the interim are we interested in a minimal patch to the specific
> scalar test that's finding this under SANITIZE=undefined, as running
> un-cleanly will be new in this release?

Yes, it is a new minor annoyance that is better left this late in the cycle.

Previous: Ævar Arnfjörð Bjarmason
Message 11 of 11 in “What's cooking in git.git (Sep 2022, #08; Tue, 27)”
  1. Junio C HamanoSep 27, 2022
  2. Victoria DyeSep 28, 2022
  3. vd/fix-unaligned-read-index-v4, was Re: What's cooking in git.git (Sep 2022, #08; Tue, 27)Jeff King, Sep 28, 2022
  4. 1/3 pack-bitmap: make read_be32() publicJeff King, Sep 28, 2022
  5. 2/3 read-cache: read on-disk entries in byte orderJeff King, Sep 28, 2022
  6. Jeff KingSep 29, 2022
  7. Junio C HamanoSep 29, 2022
  8. 3/3 read-cache: use read_be32() in create_from_disk()Jeff King, Sep 28, 2022
  9. Junio C HamanoSep 28, 2022
  10. Ævar Arnfjörð BjarmasonSep 28, 2022
  11. Junio C HamanoSep 28, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.