Re: [PATCH v3] line-range: Fix infinite loop bug with degenerate '$' regex

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 18, 2022, 01:33 UTC
Message-ID: <xmqqa63lzeb0.fsf@gitster.g>
In-Reply-To: <20221214145341.sonppjtshwqoxs6n@oddbit.com>

Lars Kellogg-Stedman <lars@oddbit.com> writes:

Show 13 quoted lines

>> > @@ -161,6 +160,7 @@ static const char *find_funcname_matching_regexp(xdemitconf_t *xecfg, const char
>> >  			return bol;
>> >  		start = eol;
>> >  	}
>> > +	return NULL;
>> >  }
>> 
>> What is this change about?  Isn't the above an endless loop without
>> break, from which the only way for the control to leave it is by
>> returning?
>
> It's not an endless loop without break; this change modified the loop
> condition:

Ah, thanks, that's clear, and sorry for the noise, and thanks.