git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] builtin/repack.c: avoid making cruft packs preferred

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 3, 2023, 20:20 UTC
Message-ID
<xmqqa5szzcdz.fsf@gitster.g>
In-Reply-To
<ZRxBlrjyuBmJnx3p@nand.local>
Taylor Blau <me@ttaylorr.com> writes:
Show 17 quoted lines
> On Tue, Oct 03, 2023 at 12:27:51PM -0400, Taylor Blau wrote:
>> I've had this sitting in my patch queue for a while now. It's a
>> non-critical performance fix that avoids the repack/MIDX machinery from
>> ever choosing a cruft pack as preferred when writing a MIDX bitmap
>> without a given --preferred-pack.
>>
>> There is no correctness issue here, but choosing a pack with few/no
>> reachable objects means that our pack reuse mechanism will rarely kick
>> in, resulting in performance degradation.
>>
>>  builtin/repack.c        | 47 ++++++++++++++++++++++++++++++++++++++++-
>>  t/t7704-repack-cruft.sh | 39 ++++++++++++++++++++++++++++++++++
>>  2 files changed, 85 insertions(+), 1 deletion(-)
>
> Oops, I should have mentioned that this is meant to be applied on top of
> 'tb/multi-cruft-pack' to reduce the conflict resolution burden. Sorry
> about that.

Sorry, but I do not follow. tb/multi-cruft-pack was merged to 'master' at c0b5d46d (Documentation/gitformat-pack.txt: drop mixed version section, 2023-08-28) but back then t7704 did not exist. Do you mean the other topic in-flight from you about max-cruft-size?

Previous: Taylor BlauNext: Taylor Blau
Message 3 of 10 in “builtin/repack.c: avoid making cruft packs preferred”
  1. builtin/repack.c: avoid making cruft packs preferredTaylor Blau, Oct 3, 2023
  2. Taylor BlauOct 3, 2023
  3. Junio C HamanoOct 3, 2023
  4. Taylor BlauOct 3, 2023
  5. Jeff KingOct 3, 2023
  6. Taylor BlauOct 3, 2023
  7. builtin/repack.c: avoid making cruft packs preferredTaylor Blau, Oct 3, 2023
  8. Jeff KingOct 4, 2023
  9. Patrick SteinhardtOct 5, 2023
  10. Eric SunshineOct 5, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.