Re: [Improvements on messages 0/5] Disambuiguate between options and commands

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 16, 2024, 18:43 UTC
Message-ID: <xmqqa5o0i71o.fsf@gitster.g>
In-Reply-To: <20240216101647.28837-1-ash@kambanaria.org>

Alexander Shopov <ash@kambanaria.org> writes:

Show 8 quoted lines

> These are trivial fixes to messages.
> They make sure commands and options are markes as such.
> This will help translators and end users.
> This will also reduce the special cases Jiang Xin keeps
> for git-po-helper which will ease maintenance.
>
> I am basing these on maint but I have also checked that
> they ar still relevant by cherry picking on top of latest and next.

I've looked at all of them and they looked sensible.

The changes look like this:

	-	die(_("something option something: %s"), arg);
	+	die(_("something --option something: %s"), arg);

It is not a fault of this patch, but wasn't the concensus that the ideal form would be more like this:

		die(_("something %s something: %s"), "--option", arg);

in order to completely avoid tempting translators into touching "--option", IIRC?

These patches do not make things worse, so I am willing to say they are strict improvements and the series is a good first step if we wanted to follow through to eject option names out of translatable strings later.

Thanks.