git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/1] completion: don't complete revs when --no-format-patch

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 21, 2024, 01:34 UTC
Message-ID
<xmqqa5nusiqv.fsf@gitster.g>
In-Reply-To
<CAC4O8c88Z3ZqxH2VVaNPpEGB3moL5dJcg3cOWuLWwQ_hLrJMtA@mail.gmail.com>
Britton Kerin <britton.kerin@gmail.com> writes:
Show 11 quoted lines
>> While this second hunk here makes perfect sense to me, there is no
>> explanation why we need to change `__git_find_last_on_cmdline ()`. It's
>> already used with "--guess --no-guess" in another place, so I would
>> think that it ought to work alright for this usecase, too. Or is it that
>> the existing callsite of this function is buggy, too? If so, we should
>> likely fix that in a separate patch together with a test.
>>
>> Also, adding a test for git-send-email that exercises this new behaviour
>> would be very much welcome, too.
>
> I'll look this one over again and add some tests eventually.
Thank you, both.
Previous: Britton KerinNext: Junio C Hamano
Message 9 of 11 in “completion: send-email: don't complete revs when --no-format-patch”
  1. 0/1 completion: send-email: don't complete revs when --no-format-patchBritton Leo Kerin, Jan 8, 2024
  2. Dragan SimicJan 8, 2024
  3. Britton KerinJan 8, 2024
  4. 0/1 completion: don't complete revs when --no-format-patchBritton Leo Kerin, Jan 9, 2024
  5. 1/1 completion: don't complete revs when --no-format-patchBritton Leo Kerin, Jan 9, 2024
  6. Junio C HamanoFeb 7, 2024
  7. Patrick SteinhardtFeb 8, 2024
  8. Britton KerinFeb 14, 2024
  9. Junio C HamanoFeb 21, 2024
  10. Junio C HamanoMar 5, 2024
  11. Junio C HamanoApr 28, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.