git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] config.c: avoid segfault with --fixed-value and valueless config

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 5, 2024, 15:45 UTC
Message-ID
<xmqqa5hr55yb.fsf@gitster.g>
In-Reply-To
<ZrDH3ryOO0wIJIDE@tanuki>
Patrick Steinhardt <ps@pks.im> writes:
Show 5 quoted lines
> Edge cases like this really make me wonder what the benefit of implicit
> bools is in our config files.
>
> So... why do we have them in the first place? Is there even a single
> good reason?

There isn't any good reason to introduce such a syntax if we were desigining the configuration file format from scratch. It was added because originally Linus thought it was a cute syntax, and these days a lot lot more importantly, it is kept working because you will break a lot of existing configuration files that were hand tweaked if you remove the support suddenly.

Previous: Patrick SteinhardtNext: Taylor Blau
Message 3 of 5 in “config.c: avoid segfault with --fixed-value and valueless config”
  1. config.c: avoid segfault with --fixed-value and valueless configTaylor Blau, Aug 1, 2024
  2. Patrick SteinhardtAug 5, 2024
  3. Junio C HamanoAug 5, 2024
  4. Taylor BlauAug 5, 2024
  5. Patrick SteinhardtAug 6, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.