git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] doc: mention rev-list --ancestry-path restrictions

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 3, 2024, 23:33 UTC
Message-ID
<xmqqa5dc9wa5.fsf@gitster.g>
In-Reply-To
<3bf4e4bc-c807-4bbb-8920-afba077413b4@app.fastmail.com>
"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:
> Hello Kai
>
> I couldn’t apply this patch to `master` (cc01bad4a9f (The twelfth batch,
> 2024-11-27)). It looks like it is because..

yes it is heavily whitespace damaged. Here is what I applied after manually reconstructing.

--- >8 ---
From: Kai Koponen <kaikoponen@google.com>
Date: Tue, 3 Dec 2024 12:14:34 -0500
Subject: [PATCH] doc: mention rev-list --ancestry-path restrictions

The rev-list documentation doesn't mention that the given commit must be in the specified commit range, leading to unexpected results.

Signed-off-by: Kai Koponen <kaikopone@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 Documentation/rev-list-options.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/rev-list-options.txt b/Documentation/rev-list-options.txt
index 0d90d5b154..9d5243e0aa 100644
--- a/Documentation/rev-list-options.txt
+++ b/Documentation/rev-list-options.txt
@@ -401,7 +401,8 @@ Default mode::
 
 --ancestry-path[=<commit>]::
 	When given a range of commits to display (e.g. 'commit1..commit2'
-	or 'commit2 {caret}commit1'), only display commits in that range
+	or 'commit2 {caret}commit1'), and a commit <commit> in that range,
+	only display commits in that range
 	that are ancestors of <commit>, descendants of <commit>, or
 	<commit> itself.  If no commit is specified, use 'commit1' (the
 	excluded part of the range) as <commit>.  Can be passed multiple
-- 
2.47.1-529-gecd20ec0f1
Previous: Kai KoponenNext: Kai Koponen
Message 10 of 12 in “rev-list --ancestry-path with arg - bug or undocumented requirement”
  1. Kai KoponenNov 19, 2024
  2. Elijah NewrenNov 20, 2024
  3. Kai KoponenDec 2, 2024
  4. Elijah NewrenDec 2, 2024
  5. Junio C HamanoDec 3, 2024
  6. doc: mention rev-list --ancestry-path restrictionsKai Koponen, Dec 3, 2024
  7. Kristoffer HaugsbakkDec 3, 2024
  8. Kai KoponenDec 3, 2024
  9. Kai KoponenDec 3, 2024
  10. Junio C HamanoDec 3, 2024
  11. Kai KoponenDec 3, 2024
  12. Junio C HamanoDec 3, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.