Re: [PATCH v2 00/12] coverity: fix leaks and error paths
Patrick Steinhardt <ps@pks.im> writes:
Show 28 quoted lines
> On Sun, Jul 05, 2026 at 08:24:17AM +0000, Johannes Schindelin via GitGitGadget wrote:
>> I wanted to whittle down the many issues reported by Coverity in the Git for
>> Windows project. Turns out: The vast majority of the issues are false
>> positives. Most of the remaining issues are in core Git proper.
>>
>> This effort was forced on pause while Coverity was down from May 16
>> [https://web.archive.org/web/20260516152422/https://scan.coverity.com/] to
>> June 22
>> [https://web.archive.org/web/20260622182153/https://scan.coverity.com/]).
>>
>> Here is a first batch of fixes for those issues.
>>
>> Changes since v1:
>>
>> * Edited the commit messages to put function names in backticks, and
>> reflowed the messages afterwards.
>> * Took Junio's suggestion to avoid (ab-)using errno to determine the return
>> value of load_one_loose_object_map().
>> * Dropped the obsolete patch "run_diff_files: avoid memory leak".
>> * Rewrote the commit message of "dir: free allocations on parse-error paths
>> in read_one_dir()" to clarify ownership of the allocated untracked/dirs
>> buffers.
>> * Changed "submodule: fix cwd leak in get_superproject_working_tree()" to
>> reduce the cognitive load on the reader (i.e. to make it a lot easier to
>> reason about the correctness of the patch).
>
> Thanks. The reflow of the commit messages made the range-diff somewhat
> hard to read, but from all I could see the changes all make sense.
Yup, this round looks good to me, too. Thanks, both.