git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Clear fd after closing to avoid double-close error

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 22, 2013, 18:42 UTC
Message-ID
<xmqq8uxltaeh.fsf@gitster.dls.corp.google.com>
In-Reply-To
<CACsJy8DtvaojrrQr4=uYCRse7N+SXb+WdjY+C_0FRSjYsNC6zg@mail.gmail.com>
Duy Nguyen <pclouds@gmail.com> writes:
Show 10 quoted lines
> On Tue, Oct 22, 2013 at 7:10 PM, Jens Lindström <jl@opera.com> wrote:
> ...
>> +               if (!args->stateless_rpc)
>> +                       /* Closed by pack_objects() via start_command() */
>> +                       fd[1] = -1;
>>         }
> ...
> Life would have been simpler if fd[1] was _always_ closed by
> send_pack(), like in c20181e (start_command(), if .in/.out > 0, closes
> file descriptors, not the callers - 2008-02-21).

Yeah, that was also my first reaction when I saw the above three lines after reading the discussion that led to the diagnosis.

Previous: Jens LindströmNext: Jens Lindström
Message 4 of 6 in “Clear fd after closing to avoid double-close error”
  1. Clear fd after closing to avoid double-close errorJens Lindström, Oct 22, 2013
  2. Duy NguyenOct 22, 2013
  3. Jens LindströmOct 22, 2013
  4. Junio C HamanoOct 22, 2013
  5. Jens LindströmOct 23, 2013
  6. Junio C HamanoOct 23, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.