Re: [PATCH 3/4] line-log: convert to using diff_tree_sha1()

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 6, 2014, 21:50 UTC
Message-ID: <xmqq8utnykq2.fsf@gitster.dls.corp.google.com>
In-Reply-To: <87wqh8arb2.fsf@thomasrast.ch>

Thomas Rast <tr@thomasrast.ch> writes:

Show 15 quoted lines

> Kirill Smelkov <kirr@mns.spb.ru> writes:
>
>> Since diff_tree_sha1() can now accept empty trees via NULL sha1, we
>> could just call it without manually reading trees into tree_desc and
>> duplicating code.
>>
>> Cc: Thomas Rast <tr@thomasrast.ch>
>> Signed-off-by: Kirill Smelkov <kirr@mns.spb.ru>
>> ---
>>  line-log.c | 26 ++------------------------
>>  1 file changed, 2 insertions(+), 24 deletions(-)
>
> You have to love a diffstat like that :-)
>
> Thanks.

Yes, indeed.  Thanks.