Re: Bug v1.9.3: Spurious whitespace warnings when using git apply with the --exclude option

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 6, 2014, 20:12 UTC
Message-ID: <xmqq8un1ml7e.fsf@gitster.dls.corp.google.com>
In-Reply-To: <332C033B-7809-45A9-9F91-CC3A92090B86@apple.com>

Peyton Randolph <prandolph@apple.com> writes:

Show 6 quoted lines

> Bug v1.9.3: Spurious whitespace warnings when using git apply with the --exclude option
> ...
> EXPECTED RESULT:
> No warning about adding whitespace errors because no whitespace
> errors are added to the tree since A is excluded and B has no
> whitespace errors.

By reading the way the code is structured, I would expect (I didn't check) that all versions of apply that supports whitespace error detection with include/exclude option to share this symptom, and this bug is not specific to 1.9.3.

In order to decide if a hunk with a new whitespace error should be reported, the program needs to parse the patch input to at least find out what path the part being parsed is to be applied, and the whitespace error detection and reporting is done when the patch input is parsed. After the part that applies to one path is fully parsed, it then checks to see if the path is included/excluded and omits it from the --stat output and also actual application.

That part of the code needs to be restructured so that at least error reporting (and preferrably error detection) is not done when the path is known to be excluded. Let me see if this can be easily done.

Thanks.