Re: [RFC PATCHv2 1/2] am: add gitk patch format

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 5, 2014, 18:29 UTC
Message-ID: <xmqq8ulxrkeq.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CAFOYHZDfpZPvuE_BZQHajc65fZNKoyqvFf+UZyf0LyLwrooqzA@mail.gmail.com>

Chris Packham <judge.packham@gmail.com> writes:

> So teaching git mailinfo to do s/^    // (either when asked to or
> using some heuristic) would be a better approach? I also think we
> should accept "Author:" as an acceptable fallback if "From:" is not
> present.

Not as "a fallback" in the sense that "Author:" should not be treated any specially when "am" (which stands for "apply mail") is operating on the patches in e-mails. Whatever wants to convert the output from "log --pretty" as if it came from "log --pretty=email" would certainly need to flip "Author:" to "From:" (what should happen when it sees "From:" in the input, though???), and whatgver wannts to pick metainfo from "log --pretty" output like mailinfo does for "log --pretty=email" output would certainly need to pick the authorship from "Author:" (without paying any attention to "From:" if one exists).