Re: [PATCH v2] compat: convert modes to use portable file type values

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 4, 2014, 19:39 UTC
Message-ID: <xmqq8uintdaw.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CAEvUa7nxzX=54QJto_R3hfvAO4FKhs8Pancz0TTiC7ev22--Kw@mail.gmail.com>

David Michael <fedora.dm0@gmail.com> writes:

Show 12 quoted lines

> On Wed, Dec 3, 2014 at 9:24 PM, David Michael <fedora.dm0@gmail.com> wrote:
>> --- /dev/null
>> +++ b/compat/stat.c
>> @@ -0,0 +1,49 @@
>> +#define _POSIX_C_SOURCE 200112L
>> +#include <stddef.h>    /* NULL         */
>> +#include <sys/stat.h>  /* *stat, S_IS* */
>> +#include <sys/types.h> /* mode_t       */
>
> Oops, the <stddef.h> line can be removed now that this is no longer
> testing for NULL.  Let me know if this warrants a v3 if there is no
> other feedback.

Let me queue with this squashed in for now.

 compat/stat.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/compat/stat.c b/compat/stat.c
index c2d4711..a2d3931 100644
--- a/compat/stat.c
+++ b/compat/stat.c
@@ -1,5 +1,4 @@
 #define _POSIX_C_SOURCE 200112L
-#include <stddef.h>    /* NULL         */
 #include <sys/stat.h>  /* *stat, S_IS* */
 #include <sys/types.h> /* mode_t       */