git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] t0027: Support NATIVE_CRLF

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 17, 2015, 21:04 UTC
Message-ID
<xmqq8udqpius.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1db9b0b7322c3b8b8e7a76b29b020ad8@www.dscho.org>
Johannes Schindelin <johannes.schindelin@gmx.de> writes:
Show 21 quoted lines
> Hi Torsten,
>
> On 2015-04-17 17:44, Torsten Bögershausen wrote:
>> Without this patch, t0027 expects the native end-of-lines to be a single
>> line feed character. On Windows, however, we set it to a carriage return
>> character followed by a line feed character. Thus, we have to modify
>> t0027 to expect different warnings depending on the end-of-line markers.
>> 
>> Adjust the check of the warnings and use these macros:
>>   WILC:  Warn if LF becomes CRLF
>>   WICL:  Warn if CRLF becomes LF
>>   WAMIX: Mixed line endings: either CRLF->LF or LF->CRLF
>> 
>> Improve the information given by check_warning():
>> Use test_cmp to show which warning is missing (or should'n t be there)
>> 
>> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>> Signed-off-by: Torsten Bögershausen <tboegi@web.de>
>
> Thank you so much!
> Dscho
Thanks, is that "Acked-by: Dscho" for both patches?
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 5 of 7 in “t0027: Support NATIVE_CRLF”
  1. 2/2 t0027: Support NATIVE_CRLFTorsten Bögershausen, Apr 17, 2015
  2. Torsten BögershausenApr 17, 2015
  3. Johannes SchindelinApr 17, 2015
  4. Johannes SchindelinApr 17, 2015
  5. Junio C HamanoApr 17, 2015
  6. Johannes SchindelinApr 18, 2015
  7. Eric SunshineApr 17, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.