Re: [PATCHv3] refs.c: enable large transactions

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 24, 2015, 01:37 UTC
Message-ID: <xmqq8udi2tn8.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CAGZ79kYO9NifvWQ7nWHP6==ZFmrMj47-94rEHOhWooR5Nh7EUw@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

Show 11 quoted lines

> On Thu, Apr 23, 2015 at 10:56 AM, Junio C Hamano <gitster@pobox.com> wrote:
>
>>> +             int save_errno = errno;
>>> +             error("Couldn't reopen %s", lock->lk->filename.buf);
>>
>> No need to change this line, but I noticed that we might want to do
>> something about the first one of the following two:
>
> I personally like to have each error(...) to have a unique string, such
> that when you run into trouble (most likely reported by a user),
> you can easily pinpoint where the exact error is.

I was hoping that the "grep" patterns were strong enough hint, but let me be explicit. I was commenting on "Could" not being spelled as "could".

>>     $ git grep -e '[    ]error(_*"[A-Z]' | wc -l
>>     146
>>     $ git grep -e '[    ]error(_*"[a-z]' | wc -l
>>     390