Re: [RFC/PATCH] log: add log.firstparent option
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 24, 2015, 15:07 UTC
- Message-ID
- <xmqq8ua5oapm.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <20150724072325.GC2111@peff.net>
Jeff King <peff@peff.net> writes:
Show 18 quoted lines
> On Thu, Jul 23, 2015 at 03:46:33PM -0700, Junio C Hamano wrote: > >> Admittedly, that >> merely is saying that "--first-parent" is not a solution to such a >> project, and does not say much about the usefulness of the new >> configuration, so I'd queue it as-is. > > Yeah, I agree that this patch does not make a judgement on particular > workflows, and can stand on its own. I buried a related deep in a > footnote in my other email, so let me bring it up again here. > > I am not entirely convinced this won't bite somebody who gets a sha1 > from some other source, and then wants to run: > > git log $some_other_sha1 > > who might be quite confused to start a first-parent traversal from > somewhere other than the tip of "master" or the tip of a topic branch.
Yeah, you actually convinced me reasonably well that it would happen. I'd never use it myself. If people want to shoot themselves in the foot, be my guest ;-)
Perhaps we should drop this, and give a shorter synonym to the option? .