Re: [PATCH v4 3/3] Move all the SHA1 implementations into one directory
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 5, 2015, 18:29 UTC
- Message-ID
- <xmqq8u6c711m.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <1446705523-30701-3-git-send-email-apahlevan@ieee.org>
atousa.p@gmail.com writes:
Show 8 quoted lines
> From: Atousa Pahlevan Duprat <apahlevan@ieee.org> > > The various SHA1 implementations were spread around in 3 directories. > This makes it easier to understand what implementations are > available at a glance. > > Signed-off-by: Atousa Pahlevan Duprat <apahlevan@ieee.org> > ---
I am not strongly opposed to moving block and ppc (I am not strongly for the movement, either, though).
I however think the chunked one should not be mixed together with them--it is not a full SHA-1 hash implementation but belongs to a different layer of abstration (and that is the reason why we introduced a new layer of indirection in 1/3).