Re: [PATCH v2 2/2] git-p4: fix Git LFS pointer parsing
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 20, 2016, 18:30 UTC
- Message-ID
- <xmqq8u08w2tb.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <CAHGBnuOjb+zmzwJeY-hbU4MYKpOMCQSRtDC4hS4zvCD5DQzv3w@mail.gmail.com>
Sebastian Schuberth <sschuberth@gmail.com> writes:
Show 11 quoted lines
> Why do we need to remove the preamble at all, if present? If all we
> want is the oid, we should simply only look at the line that starts
> with that keyword, which would skip any preamble. Which is what you
> already do here. However, I'd probably use .splitlines() instead of
> .split('\n') and .startswith('oid ') (note the trailing space) instead
> of .startswith('oid') to ensure "oid" is a separate word.
>
> But then again, I wonder why there's so much split() logic involved in
> extracting the oid. Couldn't we replace all of that with a regexp like
>
> oid = re.search(r"^oid \w+:(\w+)", pointerFile, re.MULTILINE).group(1)Yup, all of that is a very useful suggestion. If we know how the piece of information we want is identified in the output, specifically looking for it would future-proof the code better, as it will not be affected by future change that adds unexpected cruft to the output we are reading from.