Re: [PATCH v2] fix pushing to //server/share/dir on Windows

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 15, 2016, 17:49 UTC
Message-ID: <xmqq8trhw091.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20161215110155.it7ptkbju5etmnpn@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 8 quoted lines

> I don't have an opinion either way on what Windows would want, but note
> that the function already _does_ convert separators to slashes. With
> Johannes's original patch, you'd end up with a mix, like:
>
>   \\server\share/dir1/file
>
> So this conversion is really just retaining the original behavior, and
> making it consistent throughout the path.

Show 8 quoted lines

>
> Which isn't to say that the function as it currently exists isn't a
> little bit buggy. :)
>
> One of the points of normalizing, though, is that Git can then do
> textual comparisons between the output. So I think there's value in
> having a canonical internal representation, even if the OS could handle
> more exotic ones.

E.g. the log message of d53c2c6738 ("mingw: fix t9700's assumption about directory separators", 2016-01-27) says the two kinds of slashes are equivalent over there, but the patch text ends up doing exactly that normalization.

5ca6b7bb47 ("config --show-origin: report paths with forward slashes", 2016-03-23) is an example of us trying to normalize in order to give consistent output to the users.

Having said all that, I do not have an opinion either way on what Windows would want, either ;-)