Re: [PATCH] http(s): automatically try NTLM authentication first

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 22, 2017, 21:16 UTC
Message-ID: <xmqq8toyapu6.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <97ab9a812f7b46d7b10d4d06f73259d8@exmbdft7.ad.twosigma.com>

David Turner <David.Turner@twosigma.com> writes:

Show 9 quoted lines

> Always, no.  For failed authentication (or authorization), apparently, yes.  
> I tested this by  setting the variable to false and then true, and trying to 
> Push to a github repository which I didn't have write access to, with 
> both an empty username (https://@:github.com/...) and no username 
> (http://github.com/...).   I ran this under GIT_CURL_VERBOSE=1 and
> I saw two 401 responses in the "http.emptyauth=true" case and one
> in the false case.  I also tried with a repo that I did have access to (first
> configuring the necessary tokens for HTTPS push access), and saw two
> 401 responses in *both* cases.

Thanks; that matches my observation. I do not think we care about an extra roundtrip for the failure case, but as long as we do not increase the number of roundtrip in the normal case, we can declare that this is an improvement. I am not quite sure where that extra 401 comes from in the normal case, and that might be an indication that we already are doing something wrong, though.