Re: [PATCH v4] commit: check result of resolve_ref_unsafe

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 22, 2017, 00:46 UTC
Message-ID: <xmqq8tg4f1qb.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171021061921.xtocfdfik6ehhwzw@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 11 quoted lines

>> Hello,
>> I think this way is better for user experience:
>> * git doesn't crash;
>> * warning is shown;
>> * commit has been successfully created then it's safe to show a summary message
>> with already known information and without resolved HEAD.
>
> I'm on the fence between this and the die_errno() version. Given that
> this would basically never happen in practice, I don't think it matters
> too much. And that makes me want to just err on the side of simplicity.
> But it's not like this is all that complex, either.

True.  I've queued v3 for now.

Thanks, both.