Re: [PATCH] sequencer: make sign_off_header a file local symbol

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 21, 2017, 03:10 UTC
Message-ID: <xmqq8tf0jpia.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqqy3n0jv98.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 21 quoted lines

> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
>
>> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
>> ---
>>
>> Hi Miklos,
>>
>> If you need to re-roll your 'mv/cherry-pick-s' branch, could you
>> please squash this into the relevant patch (commit 5ed75e2a3f,
>> "cherry-pick: don't forget -s on failure", 14-09-2017).
>
> What automated procedure are you using to produce these comments?
>
> The commit is from 14-09-2012, not from a few months ago, and is
> part of Git 1.8.0 and upwards, which won't be rerolled.  Please add
> a check to see if the culprit is already in 'next' or something.
>
> Will queue as _your_ fix, not a potential squash into another
> commit.
>
> Thanks, as always, for your attention to detail.

Yuck. Somebody in flight does use this symbol from elsewhere, so it cannot be made static. Let's drop this patch for now.