git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] hooks/pre-auto-gc-battery: allow gc to run on non-laptops

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 28, 2018, 21:57 UTC
Message-ID
<xmqq8tbckca1.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20180228214654.t4rcqmcb37q3grdh@angband.pl>
Adam Borowski <kilobyte@angband.pl> writes:
> 0 usually means a laptop on AC power, 255 is for a typical desktop.
> The current code can't return 2 or any other unexpected value, but if it
> ever does, an unknown error should probably be treated same as 255 unknown.
> Thus, gc should be avoided only if the return code is 1.

In short, your answer to my question is "What the code does is the more correct version between the two---the log message was lying."

Then please do not talk about 255 but explain why "only if it is 1" is the right thing in the log message. That would make the result consistent.

> As for the second paragraph,...
That paragraph reads just fine.
Previous: Adam BorowskiNext: Adam Borowski
Message 4 of 6 in “hooks/pre-auto-gc-battery: allow gc to run on non-laptops”
  1. hooks/pre-auto-gc-battery: allow gc to run on non-laptopsAdam Borowski, Feb 28, 2018
  2. Junio C HamanoFeb 28, 2018
  3. Adam BorowskiFeb 28, 2018
  4. Junio C HamanoFeb 28, 2018
  5. hooks/pre-auto-gc-battery: allow gc to run on non-laptopsAdam Borowski, Feb 28, 2018
  6. Junio C HamanoFeb 28, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.