Re: git remote rename problem with trailing \\ for remote.url config entries (on Windows)

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 10, 2018, 23:31 UTC
Message-ID: <xmqq8t9u1vwd.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <nycvar.QRO.7.76.6.1804110020380.56@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 8 quoted lines

> A quick test with my `empty-config-section` patch series shows that it
> addresses this issue. A quick bisec confirms that the patch with the
> online "git_config_set: make use of the config parser's event stream" is
> responsible for this fix.
>
> At first, I was puzzled by this, because I expected `git remote rename` to
> be backed by the `git_config_copy_or_rename_section_in_file()` function
> (which my patch series does not touch).

I played around with this test data:

        [sec "tio"]
                val = a\\
                ue = b

and saw "git config --rename-section sec.tio sec.tion" just work fine (without the event stream change). Without the event stream change, "git config --unset sec.tio.ue" loses "sec.tio.val" but with it we see we only lose the last line, which is the correct thing to happen.

Nice.