Re: [PATCH v2 0/3] Clear flags before each v2 request

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 19, 2018, 03:19 UTC
Message-ID: <xmqq8t2u39ok.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <cover.1539893192.git.jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

> Jonathan Tan (3):
>   upload-pack: make have_obj not global
>   upload-pack: make want_obj not global
>   upload-pack: clear flags before each v2 request

It took a bit of time why 2/3 did not apply cleanly but it turns out this is based on a slightly older tip of 'master' (but still ahead of 'maint'), that lacks 829a3215 ("commit-graph: close_commit_graph before shallow walk", 2018-08-20). Applying and merging it to make it up-to-date with the tip of 'master' went smoothly once I figured it out.

The first two clean-up patches are probably overdue and worth doing regardless of the bugfix. Nicely done.

The first two steps use static objects local to a transport method to "preserve the existing behaviour", and because this codepath happens to want a clean slate every time it gets called, the third step manages to lose it, which is a nice progression. But it makes me wonder if it also hints that there may be a need to invent a state object that is passed around from the transport layer across requests, if we want to fulfill a request by calling multiple transport methods in the future. In any case, there is no immediate need to address this comment ;-).

Will replace.  Thanks.