git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] t3422: mark two test cases as requiring support for `--preserve-merges`

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 25, 2019, 16:23 UTC
Message-ID
<xmqq8ssmqe02.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<ed41e8d7abc93603063e9a99f628548608413d34.1564046191.git.gitgitgadget@gmail.com>

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 16 quoted lines
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> We started marking all of those test cases that require `git rebase -p`
> to work in the recent past, to allow for skipping them (because the
> `--preserve-merges` backend is already deprecated and will be removed in
> one of the next major versions, so it is a bit pointless to test its
> functionality all the time).
>
> This patch marks two previously forgotten test cases with the `REBASE_P`
> prerequisite, to allow skipping them via setting the environment
> variable `GIT_TEST_SKIP_REBASE_P`.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
>  t/t3422-rebase-incompatible-options.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
Thanks.
Show 20 quoted lines
>
> diff --git a/t/t3422-rebase-incompatible-options.sh b/t/t3422-rebase-incompatible-options.sh
> index bb78a6ec86..eb5cb67b06 100755
> --- a/t/t3422-rebase-incompatible-options.sh
> +++ b/t/t3422-rebase-incompatible-options.sh
> @@ -65,12 +65,12 @@ test_rebase_am_only --ignore-whitespace
>  test_rebase_am_only --committer-date-is-author-date
>  test_rebase_am_only -C4
>  
> -test_expect_success '--preserve-merges incompatible with --signoff' '
> +test_expect_success REBASE_P '--preserve-merges incompatible with --signoff' '
>  	git checkout B^0 &&
>  	test_must_fail git rebase --preserve-merges --signoff A
>  '
>  
> -test_expect_success '--preserve-merges incompatible with --rebase-merges' '
> +test_expect_success REBASE_P '--preserve-merges incompatible with --rebase-merges' '
>  	git checkout B^0 &&
>  	test_must_fail git rebase --preserve-merges --rebase-merges A
>  '
Previous: Johannes Schindelin via GitGitGadgetNext: Junio C Hamano
Message 3 of 5 in “Add the REBASE_P prerequisite to two more test cases”
  1. 0/1 Add the REBASE_P prerequisite to two more test casesJohannes Schindelin via GitGitGadget, Jul 25, 2019
  2. 1/1 t3422: mark two test cases as requiring support for `--preserve-merges`Johannes Schindelin via GitGitGadget, Jul 25, 2019
  3. Junio C HamanoJul 25, 2019
  4. Junio C HamanoJul 25, 2019
  5. Johannes SchindelinJul 25, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.